From: Antonio Ospite <ospite@studenti.unina.it>
Date: Mon, 28 Feb 2011 11:35:07 +0000 (+0100)
Subject: Remove the comment about translating block titles
X-Git-Url: https://git.ao2.it/drupal_ipv6_greeter.git/commitdiff_plain/ca0a81652f796eb670853feb74cf8bebe49e77a2?hp=959fff346958d7786b7032e342d24e81f68f5134

Remove the comment about translating block titles

Thanks to RobLoach for reviewing the module and for confirming that
translating the block title with t() is actually OK.

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---

diff --git a/TODO.txt b/TODO.txt
index c5b9416..6f5dc5a 100644
--- a/TODO.txt
+++ b/TODO.txt
@@ -1,6 +1,3 @@
-Sort out how i18n should be done for block title, see the XXX comment in
-ipv6_greeter.module at line 34.
-
 Make the greeting messages configurable, maybe with documentations about using
 some predefined t() placeholders like !client_ip
 
diff --git a/ipv6_greeter.module b/ipv6_greeter.module
index cff5172..595f4b0 100644
--- a/ipv6_greeter.module
+++ b/ipv6_greeter.module
@@ -30,8 +30,6 @@ function ipv6_greeter_block($op = 'list', $delta = 0) {
   elseif ($op == 'view') {
     $title = variable_get('ipv6_greeter_blocktitle', 'IPv6 Greeter');
     if (!empty($title)) {
-      // XXX is it OK to use t() here, or we should rather let the user to define
-      // that as a multilanguage variable in $conf['i18n_variables'] ?
       $block['subject'] = t($title);
     }
     $block['content'] = _ipv6_greeter_create_content();