From ca0a81652f796eb670853feb74cf8bebe49e77a2 Mon Sep 17 00:00:00 2001 From: Antonio Ospite Date: Mon, 28 Feb 2011 12:35:07 +0100 Subject: [PATCH] Remove the comment about translating block titles Thanks to RobLoach for reviewing the module and for confirming that translating the block title with t() is actually OK. Signed-off-by: Antonio Ospite --- TODO.txt | 3 --- ipv6_greeter.module | 2 -- 2 files changed, 5 deletions(-) diff --git a/TODO.txt b/TODO.txt index c5b9416..6f5dc5a 100644 --- a/TODO.txt +++ b/TODO.txt @@ -1,6 +1,3 @@ -Sort out how i18n should be done for block title, see the XXX comment in -ipv6_greeter.module at line 34. - Make the greeting messages configurable, maybe with documentations about using some predefined t() placeholders like !client_ip diff --git a/ipv6_greeter.module b/ipv6_greeter.module index cff5172..595f4b0 100644 --- a/ipv6_greeter.module +++ b/ipv6_greeter.module @@ -30,8 +30,6 @@ function ipv6_greeter_block($op = 'list', $delta = 0) { elseif ($op == 'view') { $title = variable_get('ipv6_greeter_blocktitle', 'IPv6 Greeter'); if (!empty($title)) { - // XXX is it OK to use t() here, or we should rather let the user to define - // that as a multilanguage variable in $conf['i18n_variables'] ? $block['subject'] = t($title); } $block['content'] = _ipv6_greeter_create_content(); -- 2.1.4