From 6452a3726e5b78d670a5ccc75e6e9005fb6dc24c Mon Sep 17 00:00:00 2001
From: Antonio Ospite <ao2@ao2.it>
Date: Thu, 9 Oct 2014 11:15:00 +0200
Subject: [PATCH 1/1] Rename gst-test-rotate.sh to
 gst-test-videoconvert-background.sh

Also add an alternative pipeline to show that the problem was not with
the rotate element itself.
---
 shell/gst-test-rotate.sh                  | 11 -----------
 shell/gst-test-videoconvert-background.sh | 19 +++++++++++++++++++
 2 files changed, 19 insertions(+), 11 deletions(-)
 delete mode 100755 shell/gst-test-rotate.sh
 create mode 100755 shell/gst-test-videoconvert-background.sh

diff --git a/shell/gst-test-rotate.sh b/shell/gst-test-rotate.sh
deleted file mode 100755
index 482655c..0000000
--- a/shell/gst-test-rotate.sh
+++ /dev/null
@@ -1,11 +0,0 @@
-#!/bin/sh
-
-set -e
-
-FORMATS="ARGB BGR BGRA BGRx RGB RGBA RGBx AYUV xBGR xRGB GRAY8 GRAY16_BE GRAY16_LE"
-for format in $FORMATS;
-do
-  echo "Testing format: $format"
-  GST_PLUGIN_PATH=$(pwd) \
-  gst-launch-1.0 videotestsrc ! video/x-raw,format="$format",width=640,height=480 ! rotate angle="0.79" ! autovideoconvert ! autovideosink > /dev/null 2>&1
-done
diff --git a/shell/gst-test-videoconvert-background.sh b/shell/gst-test-videoconvert-background.sh
new file mode 100755
index 0000000..448295b
--- /dev/null
+++ b/shell/gst-test-videoconvert-background.sh
@@ -0,0 +1,19 @@
+#!/bin/sh
+#
+# Test to check that the videoconvert background color is actually black.
+#
+# Depending on the pixelformat black can be represented in different ways, and
+# videoconvert used to get some cases wrong.
+
+set -e
+
+PIPELINE='videotestsrc ! video/x-raw,format="$format",width=640,height=480 ! rotate angle="0.79" ! autovideoconvert ! autovideosink'
+PIPELINE='videotestsrc ! video/x-raw,format="$format",width=640,height=480 ! videoscale add-borders=1 ! video/x-raw,width=800,height=480,pixel-aspect-ratio=1/1 ! videoconvert ! autovideosink'
+
+FORMATS="ARGB BGR BGRA BGRx RGB RGBA RGBx AYUV xBGR xRGB GRAY8 GRAY16_BE GRAY16_LE"
+for format in $FORMATS;
+do
+  echo "Testing format: $format"
+  GST_PLUGIN_PATH=$(pwd) \
+  eval gst-launch-1.0 $PIPELINE > /dev/null 2>&1
+done
-- 
2.1.4