From: Antonio Ospite Date: Thu, 29 Sep 2011 21:05:58 +0000 (+0200) Subject: kinect_upload_fw: fix -Wmissing-prototypes warning X-Git-Tag: v0.1~17 X-Git-Url: https://git.ao2.it/kinect-audio-setup.git/commitdiff_plain/02e18316d400a4b4fcc26f2e180de5d521721f4d?ds=inline kinect_upload_fw: fix -Wmissing-prototypes warning kinect_upload_fw.c:60:6: warning: no previous prototype for ‘dump_bl_cmd’ [-Wmissing-prototypes] kinect_upload_fw.c:67:5: warning: no previous prototype for ‘get_first_reply’ [-Wmissing-prototypes] kinect_upload_fw.c:86:5: warning: no previous prototype for ‘get_reply’ [-Wmissing-prototypes] GCC emits "missing-prototypes" argument for _public_ functions without a prototype, making them static is the right fix here. --- diff --git a/kinect_upload_fw/kinect_upload_fw.c b/kinect_upload_fw/kinect_upload_fw.c index 626b963..c932908 100644 --- a/kinect_upload_fw/kinect_upload_fw.c +++ b/kinect_upload_fw/kinect_upload_fw.c @@ -57,14 +57,14 @@ typedef struct { #define fn_le32(x) (x) // TODO: support architectures that aren't little-endian -void dump_bl_cmd(bootloader_command cmd) { +static void dump_bl_cmd(bootloader_command cmd) { int i; for(i = 0; i < 24; i++) LOG("%02X ", ((unsigned char*)(&cmd))[i]); LOG("\n"); } -int get_first_reply(void) { +static int get_first_reply(void) { unsigned char buffer[512]; int res; int transferred; @@ -82,8 +82,7 @@ int get_first_reply(void) { return res; } - -int get_reply(void) { +static int get_reply(void) { unsigned char dump[512]; status_code buffer = ((status_code*)dump)[0]; int res;