From fad13942e3ab9ffbcf5494d13e11c2c17a72a1df Mon Sep 17 00:00:00 2001 From: Antonio Ospite Date: Fri, 2 Mar 2018 11:25:03 +0100 Subject: [PATCH] debian/patches: add a patch to fix udev rules Add debian/patches/contrib-add-TAG-uaccess-to-udev-rules.patch to support the systemd way to provide access to devices. The patch fixes the following lintian warning: W: libam7xxx0.1: udev-rule-missing-uaccess lib/udev/rules.d/60-libam7xxx0.1.rules:2 user accessible device missing TAG+="uaccess" N: N: The package set up a device for user access without using the uaccess N: tag. Some udev rules get the same effect using other markers enabling N: console user access using rules in /lib/udev/rules.d/70-uaccess.rules. N: Others should specify TAG+="uaccess" in the udev rule. N: N: Refer to https://wiki.debian.org/USB/GadgetSetup for details. N: N: Severity: normal, Certainty: possible N: N: Check: udev, Type: binary N: --- .../contrib-add-TAG-uaccess-to-udev-rules.patch | 52 ++++++++++++++++++++++ debian/patches/series | 1 + 2 files changed, 53 insertions(+) create mode 100644 debian/patches/contrib-add-TAG-uaccess-to-udev-rules.patch diff --git a/debian/patches/contrib-add-TAG-uaccess-to-udev-rules.patch b/debian/patches/contrib-add-TAG-uaccess-to-udev-rules.patch new file mode 100644 index 0000000..ee56378 --- /dev/null +++ b/debian/patches/contrib-add-TAG-uaccess-to-udev-rules.patch @@ -0,0 +1,52 @@ +From 220b03f13836f256a28976e4887af89d4163dbc7 Mon Sep 17 00:00:00 2001 +From: Antonio Ospite +Date: Fri, 2 Mar 2018 11:21:33 +0100 +Subject: [PATCH] contrib: add TAG+="uaccess" to udev rules +X-Face: z*RaLf`X<@C75u6Ig9}{oW$H;1_\2t5)({*|jhM/Vb;]yA5\I~93>J<_`<4)A{':UrE + +This is suggested in https://wiki.debian.org/USB/GadgetSetup + +Leave the GROUP="plugdev" mechanism for now, as it may still be used on +distributions which do not use systemd. +--- + contrib/50-am7xxx_mode_switch.rules | 2 +- + contrib/55-am7xxx.rules | 12 ++++++------ + 2 files changed, 7 insertions(+), 7 deletions(-) + +diff --git a/contrib/50-am7xxx_mode_switch.rules b/contrib/50-am7xxx_mode_switch.rules +index 4210346..50eb681 100644 +--- a/contrib/50-am7xxx_mode_switch.rules ++++ b/contrib/50-am7xxx_mode_switch.rules +@@ -1,3 +1,3 @@ + # Rule to call am7xxx_mode_switch, useful when usb-modeswitch is not available. + # Actions Microelectronics Co. Generic Display Device (Mass storage mode) +-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="1de1", ATTRS{idProduct}=="1101", MODE="0660", GROUP="plugdev", RUN+="am7xxx-modeswitch" ++ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="1de1", ATTRS{idProduct}=="1101", MODE="0660", GROUP="plugdev" TAG+="uaccess", RUN+="am7xxx-modeswitch" +diff --git a/contrib/55-am7xxx.rules b/contrib/55-am7xxx.rules +index 6dc7ccd..a8af702 100644 +--- a/contrib/55-am7xxx.rules ++++ b/contrib/55-am7xxx.rules +@@ -1,12 +1,12 @@ + # Acer C110 +-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="1de1", ATTRS{idProduct}=="c101", MODE="0660", GROUP="plugdev" ++ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="1de1", ATTRS{idProduct}=="c101", MODE="0660", GROUP="plugdev" TAG+="uaccess" + # Acer C112 +-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="1de1", ATTRS{idProduct}=="5501", MODE="0660", GROUP="plugdev" ++ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="1de1", ATTRS{idProduct}=="5501", MODE="0660", GROUP="plugdev" TAG+="uaccess" + # Aiptek PocketCinema T25 +-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="08ca", ATTRS{idProduct}=="2144", MODE="0660", GROUP="plugdev" ++ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="08ca", ATTRS{idProduct}=="2144", MODE="0660", GROUP="plugdev" TAG+="uaccess" + # Philips/Sagemcom PicoPix 1020 +-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="21e7", ATTRS{idProduct}=="000e", MODE="0660", GROUP="plugdev" ++ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="21e7", ATTRS{idProduct}=="000e", MODE="0660", GROUP="plugdev" TAG+="uaccess" + # Philips/Sagemcom PicoPix 2055 +-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="21e7", ATTRS{idProduct}=="0016", MODE="0660", GROUP="plugdev" ++ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="21e7", ATTRS{idProduct}=="0016", MODE="0660", GROUP="plugdev" TAG+="uaccess" + # Philips/Sagemcom PicoPix 2330 +-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="21e7", ATTRS{idProduct}=="0019", MODE="0660", GROUP="plugdev" ++ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="21e7", ATTRS{idProduct}=="0019", MODE="0660", GROUP="plugdev" TAG+="uaccess" +-- +2.16.2 + diff --git a/debian/patches/series b/debian/patches/series index 897d8f8..e2c3c1b 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1,2 +1,3 @@ CMakeLists.txt-bump-the-patch-version-number.patch +contrib-add-TAG-uaccess-to-udev-rules.patch doc-Doxyfile.in-set-HTML_TIMESTAMP-to-NO-to-make-the.patch -- 2.1.4