Cosmetics: sort supported_content_types, remove unneeded spaces

[tweeper.git] / tweeper.php

diff --git a/tweeper.php b/tweeper.php
index c0db320..74e9e2f 100644 (file)
--- a/tweeper.php
+++ b/tweeper.php
@@ -54,41 +54,46 @@ function get_url_info($url)
 
 function generate_enclosure($url)
 {
+  $supported_content_types = array(
+    "application/ogg",
+    "audio/aac",
+    "audio/mp4",
+    "audio/mpeg",
+    "audio/vorbis",
+    "audio/wav",
+    "audio/webm",
+    "audio/x-midi",
+    "image/gif",
+    "image/jpeg",
+    "video/avi",
+    "video/mp4",
+    "video/mpeg",
+    "video/ogg",
+  );
+
   $url_info = get_url_info($url);
 
-  switch($url_info['content_type']) {
-    case "video/avi":
-    case "image/gif":
-    case "image/jpeg":
-    case "audio/x-midi":
-    case "audio/mpeg":
-    case "video/mpeg":
-    case "audio/vorbis":
-    case "application/ogg":
-    case "audio/webm":
-    case "audio/aac":
-    case "audio/mp4":
-    case "audio/wav":
-    case "video/mp4":
-    case "video/ogg":
-      $dom = new DomDocument();
-      $enc = $dom->createElement('enclosure');
-      $enc->setAttribute( 'url', $url_info['url']);
-      $enc->setAttribute( 'length', $url_info['download_content_length']);
-      $enc->setAttribute( 'type', $url_info['content_type']);
-
-      $dom->appendChild($enc);
-
-      return $dom->saveXML($enc);
-    default:
-        return;
+  $supported = in_array($url_info['content_type'], $supported_content_types);
+  if (!$supported) {
+    error_log("Unsupported enclosure content type \"" . $url_info['content_type'] . "\" for URL: " . $url_info['url']);
+    return '';
   }
+
+  $dom = new DomDocument();
+  $enc = $dom->createElement('enclosure');
+  $enc->setAttribute('url', $url_info['url']);
+  $enc->setAttribute('length', $url_info['download_content_length']);
+  $enc->setAttribute('type', $url_info['content_type']);
+
+  $dom->appendChild($enc);
+
+  return $dom->saveXML($enc);
 }
 
 
 class Tweeper {
 
-  public function __construct($stylesheet) {
+  public function __construct($stylesheet, $generate_enclosure = FALSE) {
     $stylesheet_contents = $this->get_contents($stylesheet);
 
     $xslDoc = new DOMDocument();
@@ -96,6 +101,7 @@ class Tweeper {
 
     $this->xsltProcessor = new XSLTProcessor();
     $this->xsltProcessor->registerPHPFunctions();
+    $this->xsltProcessor->setParameter('', 'generateEnclosure', $generate_enclosure);
     $this->xsltProcessor->importStylesheet($xslDoc);
   }
 
@@ -135,32 +141,73 @@ class Tweeper {
 function usage($argv)
 {
   if (php_sapi_name() != 'cli')
-    $usage = htmlentities("{$_SERVER['SCRIPT_NAME']}?src_url=<src_url>");
+    $usage = htmlentities("{$_SERVER['SCRIPT_NAME']}?src_url=<src_url>&generate_enclosure=<0|1>");
   else
-    $usage = "{$argv[0]} <src_url>\n";
+    $usage = "{$argv[0]} [-e|-h|--help] <src_url>\n";
 
   return "usage: $usage";
 }
 
-if (isset($_GET['src_url'])) {
-  $src_url = $_GET['src_url'];
-} else if (isset($argv[1])) {
-  if ($argv[1] == "-h" || $argv[1] == "--help") {
-    echo usage($argv);
-    return 0;
+function parse_options_cli($argv, $argc)
+{
+  $options = array(
+    'generate_enclosure' => FALSE
+  );
+
+  if ($argc < 2)
+    return $options;
+
+  $cli_options = getopt("eh", array("help"));
+  foreach ($cli_options as $opt => $val) {
+    switch ($opt) {
+    case 'e':
+      $options['generate_enclosure'] = TRUE;
+      break;
+    case 'h':
+    case 'help':
+      echo usage($argv);
+      exit(0);
+    default:
+      die(usage($argv));
+    }
   }
-  $src_url = $argv[1];
-} else {
-  die(usage($argv));
+
+  $options['src_url'] = $argv[count($cli_options) + 1];
+
+  return $options;
 }
 
-$url = parse_url($src_url);
+function parse_options_query_string()
+{
+  $options = array(
+    'generate_enclosure' => FALSE
+  );
+
+  if (isset($_GET['src_url']))
+    $options['src_url'] = $_GET['src_url'];
+
+  if (isset($_GET['generate_enclosure']))
+    $options['generate_enclosure'] = $_GET['generate_enclosure'] == 1;
+
+  return $options;
+}
+
+
+if (php_sapi_name() != 'cli')
+  $options = parse_options_query_string();
+else
+  $options = parse_options_cli($argv, $argc);
+
+if (!isset($options['src_url']))
+  die(usage($argv));
+
+$url = parse_url($options['src_url']);
 if (FALSE === $url || empty($url["host"]))
-  die("Invalid url: $src_url\n");
+  die("Invalid url: ${options['src_url']}\n");
 
 $stylesheet = __DIR__ . "/rss_converter_" . $url["host"] . ".xsl";
 if (FALSE === file_exists($stylesheet))
   die("Conversion to RSS not supported: {$url["host"]}\n");
 
-$tweeper = new Tweeper($stylesheet);
-echo $tweeper->tweep($src_url);
+$tweeper = new Tweeper($stylesheet, $options['generate_enclosure']);
+echo $tweeper->tweep($options['src_url']);