tweeper: fix style issues found by Coder Sniffer

[tweeper.git] / tweeper.php

diff --git a/tweeper.php b/tweeper.php
index 9f09936..293595f 100644 (file)
--- a/tweeper.php
+++ b/tweeper.php
@@ -18,7 +18,11 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 

-require_once 'XML/Serializer.php';
+require_once 'Symfony/Component/Serializer/autoload.php';
+
+use Symfony\Component\Serializer\Serializer;
+use Symfony\Component\Serializer\Encoder\XmlEncoder;
+use Symfony\Component\Serializer\Normalizer\ObjectNormalizer;

 
 date_default_timezone_set('UTC');
 
 
 date_default_timezone_set('UTC');
 


@@ -32,12 +36,20 @@ class Tweeper {
 
   public static function epoch_to_gmdate($timestamp)
   {
 
   public static function epoch_to_gmdate($timestamp)
   {

+    if (!is_numeric($timestamp) || is_nan($timestamp)) {
+      $timestamp = 0;
+    }
+

     return gmdate('D, d M Y H:i:s', $timestamp) . ' GMT';
   }
 
   public static function str_to_gmdate($date)
   {
     $timestamp = strtotime($date);
     return gmdate('D, d M Y H:i:s', $timestamp) . ' GMT';
   }
 
   public static function str_to_gmdate($date)
   {
     $timestamp = strtotime($date);

+    if (FALSE === $timestamp) {
+      $timestamp = 0;
+    }
+

     return Tweeper::epoch_to_gmdate($timestamp);
   }
 
     return Tweeper::epoch_to_gmdate($timestamp);
   }
 


@@ -153,7 +165,7 @@ class Tweeper {
   private function load_stylesheet($host) {
     $stylesheet = "file://" . __DIR__ . "/rss_converter_" . $host . ".xsl";
     if (FALSE === file_exists($stylesheet)) {
   private function load_stylesheet($host) {
     $stylesheet = "file://" . __DIR__ . "/rss_converter_" . $host . ".xsl";
     if (FALSE === file_exists($stylesheet)) {

-      trigger_error("Conversion to RSS not supported: $host", E_USER_ERROR);
+      trigger_error("Conversion to RSS not supported for $host ($stylesheet not found)", E_USER_ERROR);

       return NULL;
     }
 
       return NULL;
     }
 


@@ -170,35 +182,50 @@ class Tweeper {
     return $xsltProcessor;
   }
 
     return $xsltProcessor;
   }
 

-  private function json_to_xml($html, $json_match_expr, $rootName) {
-    // pre-process, convert json to XML
-    $ret = preg_match($json_match_expr, $html, $matches);
-    if ($ret !== 1) {
-      trigger_error("Cannot match expression: $json_match_expr\n", E_USER_ERROR);
-      return NULL;
-    }
-
-    $data = json_decode($matches[1]);
+  private function json_to_xml($json, $root_node_name) {
+    // Apparenty the ObjectNormalizer used afterwards is not able to handle
+    // the stdClass object created by json_decode() with the default setting
+    // $assoc = false; so use $assoc = true 
+    $data = json_decode($json, $assoc = true);

     if (!$data) {
       return NULL;
     }
 
     if (!$data) {
       return NULL;
     }
 

+    $encoder = new XmlEncoder();
+    $normalizer = new ObjectNormalizer();
+    $serializer = new Serializer(array($normalizer), array($encoder));
+

     $serializer_options = array (
     $serializer_options = array (

-      'addDecl' => TRUE,
-      'encoding' => "UTF-8",
-      'indent' => '  ',
-      'rootName' => $rootName,
+      'xml_encoding' => "UTF-8",
+      'xml_format_output' => TRUE,
+      'xml_root_node_name' => $root_node_name,

     );
 
     );
 

-    $serializer = new XML_Serializer($serializer_options);
+    $xml_data = $serializer->serialize($data, 'xml', $serializer_options);
+    if (!$xml_data) {
+      trigger_error("Cannot serialize data", E_USER_ERROR);
+      return NULL;
+    }

 
 

-    $status = $serializer->serialize($data);
-    if (PEAR::isError($status)) {
-      trigger_error($status->getMessage(), E_USER_ERROR);
+    return $xml_data;
+  }
+
+  private function get_xml_instagram_com($html) {
+    // extract the json data from the html code
+    $json_match_expr = '/window._sharedData = (.*);/';
+    $ret = preg_match($json_match_expr, $html, $matches);
+    if ($ret !== 1) {
+      trigger_error("Cannot match expression: $json_match_expr\n", E_USER_ERROR);

       return NULL;
     }
 
       return NULL;
     }
 

-    return $serializer->getSerializedData();
+    return $this->json_to_xml($matches[1], 'instagram');
+  }
+
+  private function preprocess_html_facebook_com($html) {
+    $html = str_replace('<!--', '', $html);
+    $html = str_replace('-->', '', $html);
+    return $html;

   }
 
   private function html_to_xml($html, $host) {
   }
 
   private function html_to_xml($html, $host) {


@@ -232,7 +259,10 @@ class Tweeper {
       return NULL;
     }
 
       return NULL;
     }
 

-    $xsltProcessor = $this->load_stylesheet($url["host"]);
+    // Strip the leading www. to be more forgiving on input URLs
+    $host = preg_replace('/^www\./', '', $url["host"]);
+
+    $xsltProcessor = $this->load_stylesheet($host);

     if (NULL === $xsltProcessor) {
       return NULL;
     }
     if (NULL === $xsltProcessor) {
       return NULL;
     }


@@ -242,7 +272,12 @@ class Tweeper {
       return NULL;
     }
 
       return NULL;
     }
 

-    $xmlDoc = $this->html_to_xml($html, $url["host"]);
+    $preprocess_html_host_method = 'preprocess_html_' . str_replace(".", "_", $host);
+    if (method_exists($this, $preprocess_html_host_method)) {
+      $html = call_user_func_array(array($this, $preprocess_html_host_method), array($html));
+    }
+
+    $xmlDoc = $this->html_to_xml($html, $host);

     if (NULL === $xmlDoc) {
       return NULL;
     }
     if (NULL === $xmlDoc) {
       return NULL;
     }


@@ -257,12 +292,18 @@ class Tweeper {
   }
 }
 
   }
 }
 

+function is_cli()
+{
+  return (php_sapi_name() === "cli");
+}
+

 function usage($argv)
 {
 function usage($argv)
 {

-  if (php_sapi_name() != 'cli')
-    $usage = htmlentities("{$_SERVER['SCRIPT_NAME']}?src_url=<src_url>&generate_enclosure=<0|1>");
-  else
+  if (is_cli()) {

     $usage = "{$argv[0]} [-e|-h|--help] <src_url>\n";
     $usage = "{$argv[0]} [-e|-h|--help] <src_url>\n";

+  } else {
+    $usage = htmlentities("{$_SERVER['SCRIPT_NAME']}?src_url=<src_url>&generate_enclosure=<0|1>");
+  }

 
   return "usage: $usage";
 }
 
   return "usage: $usage";
 }


@@ -313,16 +354,16 @@ function parse_options_query_string()
 }
 
 
 }
 
 

-if (php_sapi_name() != 'cli') {
-  $options = parse_options_query_string();
-  $ERROR_STREAM = fopen('php://output', 'w');
-} else {
+if (is_cli()) {

   $options = parse_options_cli($argv, $argc);
   $ERROR_STREAM = fopen('php://stderr', 'w');
   $options = parse_options_cli($argv, $argc);
   $ERROR_STREAM = fopen('php://stderr', 'w');

+} else {
+  $options = parse_options_query_string();
+  $ERROR_STREAM = fopen('php://output', 'w');

 }
 
 if (!isset($options['src_url'])) {
 }
 
 if (!isset($options['src_url'])) {

-  fwrite($ERROR_STREAM, usage($argv));
+  fwrite($ERROR_STREAM, usage(is_cli() ? $argv : NULL));

   exit(1);
 }
 
   exit(1);
 }