From 632828ebf68e855872006c220337703c25d7423d Mon Sep 17 00:00:00 2001 From: Antonio Ospite Date: Thu, 8 Nov 2018 09:29:35 +0100 Subject: [PATCH 1/1] rss_converter_twitter.com.xsl: explain why the style attribute is removed Since commit 6817108 (rss_converter_twitter.com.xsl: strip the style attribute from HTML elements, 2017-06-08) the twitter.com stylesheet removes the "style" attribute from elements when copying them. This is in order to create a more visually neutral output, but also because the style attribute may even contain dangerous content: https://validator.w3.org/feed/docs/warning/DangerousStyleAttr.html However someone who reads the code may not be familiar with (or have forgotten) why this is done, so explain that in a comment to avoid them the burden of digging in the project history. --- src/rss_converter_twitter.com.xsl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/rss_converter_twitter.com.xsl b/src/rss_converter_twitter.com.xsl index 2cf1868..06ae70a 100644 --- a/src/rss_converter_twitter.com.xsl +++ b/src/rss_converter_twitter.com.xsl @@ -35,6 +35,11 @@ + -- 2.1.4