X-Git-Url: https://git.ao2.it/visomat-utils.git/blobdiff_plain/802162fefcce3cda9325199d2fde2e897408e90a..b11c925b57646ed4376c7966de1e3ede0f6a8365:/src/visomat-data-downloader.c?ds=inline diff --git a/src/visomat-data-downloader.c b/src/visomat-data-downloader.c index a5405a4..a3282ba 100644 --- a/src/visomat-data-downloader.c +++ b/src/visomat-data-downloader.c @@ -63,6 +63,7 @@ static void debug_dump_buffer(const char *filename, uint8_t *buffer, unsigned in #define STX 0x02 #define ETX 0x03 +#define DATETIME_PACKET_SIZE 15 #define BASE_YEAR 2000 typedef enum { @@ -237,7 +238,7 @@ static int decode_datetime(uint8_t *buffer, unsigned int len) struct datetime d; uint8_t *pbuffer = buffer; - if (len != 15) + if (len != DATETIME_PACKET_SIZE) return -EINVAL; code[0] = buffer[1]; @@ -304,7 +305,7 @@ static int get_response(libusb_device_handle *dev, } while (buffer[i - 1] != ETX && i < len); - /* Check the buffer is a valid response packet */ + /* Check if the buffer contains a valid response packet */ if (buffer[0] != STX || buffer[i - 1] != ETX) return -EINVAL; @@ -315,8 +316,8 @@ static int get_response(libusb_device_handle *dev, #define visomat_device libusb_device_handle static int visomat_dump_eeprom(visomat_device *dev, unsigned int user_mask) { - /* Assuming an EEPROM of 1 KiB */ - uint8_t buffer[1024] = { 0 }; + /* Assuming an EEPROM of 4 KiB */ + uint8_t buffer[4096] = { 0 }; int ret; ret = send_command(dev, VISOMAT_CMD_DUMP_EEPROM);