From 107faf9a94302652a411c3dab5ac6d6a2f7f4f29 Mon Sep 17 00:00:00 2001 From: Antonio Ospite Date: Sun, 6 May 2012 10:15:22 +0200 Subject: [PATCH 1/1] winfreed.py: handle urllib2.urlopen failures better Also make clear the difference between src_url and url and why we use url = response.geturl() to get the latter. --- winfreed.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/winfreed.py b/winfreed.py index 1192f47..a59d78e 100755 --- a/winfreed.py +++ b/winfreed.py @@ -63,8 +63,17 @@ def show(pkg): print -def download_file(url, dest_dir): - response = urllib2.urlopen(url) +def download_file(src_url, dest_dir): + try: + response = urllib2.urlopen(src_url) + except Exception, e: + if hasattr(e, 'reason'): + print 'Download failed. Reason: ', e.reason + elif hasattr(e, 'code'): + print 'Download failed. Error code: ', e.code + return + + # get the final URL after possible redirect have been followed url = response.geturl() filename = "" -- 2.1.4