Thanks to RobLoach for reviewing the module and for confirming that
translating the block title with t() is actually OK.
Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
-Sort out how i18n should be done for block title, see the XXX comment in
-ipv6_greeter.module at line 34.
-
Make the greeting messages configurable, maybe with documentations about using
some predefined t() placeholders like !client_ip
Make the greeting messages configurable, maybe with documentations about using
some predefined t() placeholders like !client_ip
elseif ($op == 'view') {
$title = variable_get('ipv6_greeter_blocktitle', 'IPv6 Greeter');
if (!empty($title)) {
elseif ($op == 'view') {
$title = variable_get('ipv6_greeter_blocktitle', 'IPv6 Greeter');
if (!empty($title)) {
- // XXX is it OK to use t() here, or we should rather let the user to define
- // that as a multilanguage variable in $conf['i18n_variables'] ?
$block['subject'] = t($title);
}
$block['content'] = _ipv6_greeter_create_content();
$block['subject'] = t($title);
}
$block['content'] = _ipv6_greeter_create_content();