winfreed.py: some TODO comments

[winfreed.git] / winfreed.py

diff --git a/winfreed.py b/winfreed.py
index 94524e1..4b4f6bb 100755 (executable)
--- a/winfreed.py
+++ b/winfreed.py
@@ -75,21 +75,27 @@ def download(pkg):
     url = response.geturl()
 
     filename = ""
-    if 'Content-Disposition' in  response.info():
-        # Use the filename the server tells us if any,
-        # re pattern from http://stackoverflow.com/questions/8035900
-        content_disposition = response.info().getheader('Content-Disposition').strip()
-        filename = re.findall("filename=(\S+)", content_disposition)[0]
 
-    if filename == "":
-        filename = urllib2.unquote(os.path.basename(response.geturl()))
+    # From http://paste.pound-python.org/show/9545/
+    # TODO: use a proper module to parse HTTP headers
+    if response.info().has_key('Content-Disposition') and len(response.info()['Content-Disposition'].split('filename=')) > 1:
+        # If the response has Content-Disposition, we take file name from it
+        filename = response.info()['Content-Disposition'].split('filename=')[1].decode('utf-8')
+        if filename[0] == '"' or filename[0] == "'":
+            filename = urllib2.unquote(filename.split('"')[1])
+    else:
+        filename =  urllib2.unquote(url.split('/')[-1].decode('utf_8'))
 
     if filename == "":
         sys.stderr.write("Debug (%s): filename: %s url: %s\n" % (pkg['package_name'], filename, url))
         return
 
+    # TODO: Add some integrity verification of downloaded files (md5, sha256?)
+
     destfile = os.path.join(OUTPUT_DIR, filename)
     if os.path.exists(destfile):
+        # TODO: check if the file is a full download from previous run,
+        # if not download again discarding the existing file?
         sys.stderr.write("Warning (%s): %s exists!\n" % (pkg['package_name'], destfile))
         return