Split out _get_URL() and _add_link() functions

[GM_direct_download_links.git] / direct_download_links.user.js

diff --git a/direct_download_links.user.js b/direct_download_links.user.js
index e3707a1..8e06997 100644 (file)
--- a/direct_download_links.user.js
+++ b/direct_download_links.user.js
@@ -37,6 +37,20 @@
  *  - use jquery, like shown in http://a32.me/2009/11/greasemonkey/
  */
 
+/* Fields supported by the "site" object.
+ *
+ * Manadatory fields:
+ *   pageURL: the URL of the page we are modifying
+ *   urlContainer: the element containing the URL to link
+ *   urlRegexp: the regular expression for finding the URL, the first
+ *              sub-pattern is taken as the URL
+ *   linkDest: the element where to place the Direct Download link
+ *
+ *
+ * Optional fields:
+ *   TODO
+ *
+ */
 var supported_sites = [
   {
     locationRegexp: /^http:\/\/video\.repubblica\.it\/.*$/,
@@ -70,9 +84,9 @@ for (i = 0; i < supported_sites.length; i++) {
 
   var result = window.location.href.match(site.locationRegexp);
   if (result) {
-    var ret = direct_download_link_add(window.location.href, site.urlContainer, site.urlRegexp, site.linkDest);
+    var ret = direct_download_link_add(window.location.href, site);
     if (!ret) {
-      alert('Cannot add the link');
+      DDL_log('Cannot add the link');
     }
   }
 }
@@ -80,37 +94,48 @@ for (i = 0; i < supported_sites.length; i++) {
 /**
  * Add a Direct Download link on the page for the specified URL
  *
- * @param pageURL: the URL of the page we are modifying
- * @param urlContainer: the element containing the URL to link
- * @param urlRegexp: the regular expression for finding the URL, the first
- *                    sub-pattern is taken as the URL
- * @param linkDest: the element where to place the Direct Download link
+ * @param: a 'site' object described above.
  *
  * @return: null on error, true on success
  */
-function direct_download_link_add(pageURL, urlContainer, urlRegexp, linkDest) {
-  var element = document.getElementById(urlContainer);
+function direct_download_link_add(pageURL, site) {
+  var element = document.getElementById(site.urlContainer);
   if (!element) {
-    alert('DirectDL (' + pageURL  + '): Cannot find the element ' + urlContainer + ' containing the URL.');
+    DDL_log('DirectDL (' + site.pageURL  + '): Cannot find the element ' + site.urlContainer + ' containing the URL.');
+    return null;
+  }
+
+  var URL = _get_URL(site, element);
+  if (!URL) {
+    DDL_log('DirectDL (' + site.pageURL + '): cannot get the URL.');
     return null;
   }
 
+  return _add_link(site, URL);
+}
+
+function _get_URL(site, element) {
   var content = element.innerHTML;
   if (!content) {
-    alert('DirectDL (' + pageURL + '): content is null, cannot find URL.');
+    DDL_log('DirectDL (' + site.pageURL + '): content is null, cannot find URL.');
     return null;
   }
 
-  var matches = content.match(urlRegexp);
+  var matches = content.match(site.urlRegexp);
   if (!matches || matches.length < 2 || !matches[1]) {
-      alert('DirectDL (' + pageURL + '): URL not found, check the urlRegexp');
+      DDL_log('DirectDL (' + site.pageURL + '): URL not found, check the urlRegexp');
       return null;
   }
   var URL = matches[1];
 
-  var links = document.getElementById(linkDest);
+  return URL;
+}
+
+function _add_link(site, URL) {
+
+  var links = document.getElementById(site.linkDest);
   if (!links) {
-    alert('DirectDl (' + pageURL + '): Cannot add the direct download link.');
+    DDL_log('DirectDl (' + site.pageURL + '): Cannot add the direct download link.');
     return null;
   }
 
@@ -127,3 +152,12 @@ function direct_download_link_add(pageURL, urlContainer, urlRegexp, linkDest) {
 
   return true;
 }
+
+function DDL_log(message) {
+  var debug = false;
+  if (debug) {
+    alert(message)
+  } else {
+    GM_log(message);
+  }
+}